❮

[PATCH] Add a inline function to eliminate duplicate code

  • Jump to comment-1
    zhjwpku@gmail.com2022-08-02T11:27:30+00:00
    abstract the logic of `scankey change attribute num to index col number` to change_sk_attno_to_index_column_num, which is a static inline function. -- Regards Junwang Zhao
    • Jump to comment-1
      mahendrakarforpg@gmail.com2022-08-02T13:23:51+00:00
      Patch is looking good to me. Thanks, Mahendrakar. On Tue, 2 Aug 2022 at 16:57, Junwang Zhao <zhjwpku@gmail.com> wrote: > abstract the logic of `scankey change attribute num to index col > number` to change_sk_attno_to_index_column_num, which is a static > inline function. > > -- > Regards > Junwang Zhao >
      • Jump to comment-1
        zhjwpku@gmail.com2022-08-05T07:56:14+00:00
        Any more reviews? On Tue, Aug 2, 2022 at 9:24 PM mahendrakar s <mahendrakarforpg@gmail.com> wrote: > > Patch is looking good to me. > > Thanks, > Mahendrakar. > > On Tue, 2 Aug 2022 at 16:57, Junwang Zhao <zhjwpku@gmail.com> wrote: >> >> abstract the logic of `scankey change attribute num to index col >> number` to change_sk_attno_to_index_column_num, which is a static >> inline function. >> >> -- >> Regards >> Junwang Zhao -- Regards Junwang Zhao